WIP: Update "What" page #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/work-in-progress
awgreene
force-pushed
the
update-what-page
branch
from
c0ac1ef to
0907d3d
Compare
asmacdo
approved these changes
Nov 17, 2020
Member
asmacdo
left a comment
asmacdo
left a comment
There was a problem hiding this comment.
Already a huge improvement. Once the "persona persona persona" replacement text renders correctly, I think this can merge.
content/what.html
Outdated
| <p class="large-text"><span>Persona, </span> | ||
| <span>persona, </span> | ||
| <span>persona.</span></p> | ||
| <p class="large-text"><span>Software Engineers, </span> |
Member
There was a problem hiding this comment.
might have to use a different class, its doing something funky
Member
Author
There was a problem hiding this comment.
I've had to revert to one-word names of personas, please review.
awgreene
force-pushed
the
update-what-page
branch
from
0907d3d to
9e8a5a5
Compare
dmesser
requested changes
Nov 17, 2020
content/what.html
Outdated
| <span>persona.</span></p> | ||
| <p class="large-text"><span>Software Engineers, </span> | ||
| <span>DevOps Engineers, </span> | ||
| <span>Cluster Admins.</span></p> |
Contributor
There was a problem hiding this comment.
I wonder if we can convey here that the best people to write an Operators are the owners / developer of said application and SRE folks. WDYT?
Member
Author
There was a problem hiding this comment.
I think the updated commit makes this point clearer as well!
awgreene
force-pushed
the
update-what-page
branch
3 times, most recently
from
e343ced to
f723736
Compare
asmacdo
reviewed
Nov 17, 2020
content/what.html
Outdated
Comment on lines
28
to
30
| <p class="large-text"><span>Developers, </span> | ||
| <span>SREs, </span> | ||
| <span>Admins.</span></p> |
awgreene
force-pushed
the
update-what-page
branch
2 times, most recently
from
0241274 to
71c1a5a
Compare
asmacdo
approved these changes
Nov 17, 2020
This commit replaces the "Lorem Ipsum" placeholder text featured on the "What" page with actual content describing who creates and who uses operators.
awgreene
force-pushed
the
update-what-page
branch
from
71c1a5a to
8035624
Compare
dmesser
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.